chore(deps): update entities to latest for Node.js 24 compatibility by kTelyakov · Pull Request #14160 · vuejs/core

kTelyakov · 2025-12-02T20:04:49Z

Summary

This PR fixes the Node.js 24 compatibility issue with @vue/compiler-core.

Problem

The entities package v4.5.0 uses lib/ directory for exports which causes ERR_PACKAGE_PATH_NOT_EXPORTED error in Node.js 24 due to stricter exports map resolution.

Solution

Updated entities to v5.0.0 which uses dist/ directory structure that is properly compatible with Node.js 24's exports resolution.

Changes

Updated entities dependency from ^4.5.0 to ^5.0.0
Changed import paths from entities/lib/decode.js to entities/dist/decode.js

Fixes #14159 14159

Summary by CodeRabbit

Chores
- Updated the "entities" dependency to v7.x in the compiler package; no user-facing behavior changes expected.
Build
- Adjusted module references and update configuration so the project now accepts updates for the "entities" package; no functional changes introduced.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-02T20:05:00Z

Walkthrough

Updated entities usage in packages/compiler-core: dependency bumped to ^7.0.0, imports and rollup externals changed from the internal path entities/lib/decode.js to the exported path entities/decode, and entities was removed from Renovate's ignore list. No runtime logic or public API changes.

Changes

Cohort / File(s)	Summary
Dependency update `packages/compiler-core/package.json`	Bumped `entities` dependency from `^4.5.0` to `^7.0.0`.
Import / external path updates `packages/compiler-core/src/parser.ts`, `packages/compiler-core/src/tokenizer.ts`, `rollup.config.js`	Replaced `entities/lib/decode.js` references with `entities/decode`. No other logic changes.
Renovate config `.github/renovate.json5`	Removed `entities` from `ignoreDeps` (Renovate will now track updates).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pay attention to:
- Correct module resolution for entities/decode across Node.js versions and build environments.
- Rollup externals/treeshake warnings after the external path change.
- Lockfile updates and transitive dependency versions.

Poem

🐰 I hopped from lib to bright export gate,
Swapped a path, updated the crate,
Node's stricter rules I now appease,
With cleaner imports I bound the breeze,
Hop on, build fast — a carrot for fate! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main objective of updating the entities dependency for Node.js 24 compatibility.
Linked Issues check	✅ Passed	The PR successfully addresses all coding requirements from #14159: upgraded entities to ^7.0.0 (exceeding minimum ^5.0.0), updated all import paths from entities/lib/decode.js to entities/decode, and removed entities from ignoreDeps to allow updates.
Out of Scope Changes check	✅ Passed	All changes are directly related to resolving the Node.js 24 compatibility issue: dependency upgrade, import path updates, renovate configuration adjustment, and rollup configuration alignment.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb60bba and 9a6640f.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

packages/compiler-core/package.json (1 hunks)

🔇 Additional comments (1)

packages/compiler-core/package.json (1)

51-51: Verify import path consistency across the codebase.

The version bump from ^4.5.0 to ^7.0.0 represents a significant jump (3 major versions). Ensure that:

All import statements in parser, tokenizer, and build configuration files have been updated from entities/lib/decode.js to entities/decode to match the new package exports

Build configuration (rollup.config.js) properly references the new import path in externals definitions

Ecosystem CI failures (vuetify, router, vue-macros, vue-i18n) are unrelated to this dependency update

This is critical as the new API path is required for Node.js 24 compatibility, but inconsistent imports would break the build.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

netlify · 2025-12-02T20:05:17Z

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name	Link
🔨 Latest commit	`f670c51`
🔍 Latest deploy log	https://app.netlify.com/projects/vue-sfc-playground/deploys/692f94832c54db00087ff457

netlify · 2025-12-02T20:05:17Z

❌ Deploy Preview for vue-next-template-explorer failed. Why did it fail? →

Name	Link
🔨 Latest commit	`f670c51`
🔍 Latest deploy log	https://app.netlify.com/projects/vue-next-template-explorer/deploys/692f948346ce790008b6047c

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/compiler-core/src/parser.ts (1)

49-49: Deep import into entities/dist/decode.js is OK for v5 but may hinder future upgrades

This path looks consistent with entities v5’s dist layout and fixes the immediate Node 24 issue. However, newer entities releases publish only . / ./decode / ./escape in their "exports" map, not ./dist/decode.js, so a future bump beyond ^5.x would likely break here with another ERR_PACKAGE_PATH_NOT_EXPORTED. Consider switching to the public subpath (entities/decode) once you’ve confirmed it’s exported in 5.0.0 as well, or at least leave a note that this import must be revisited when upgrading entities again.

Would you double‑check entities 5.0.0’s package.json exports and confirm whether ./decode is available (and whether ./dist/decode.js is explicitly exported) before locking in this path?

packages/compiler-core/src/tokenizer.ts (1)

34-39: Non‑browser decode import is correct for entities v5; watch for future exports changes

Routing DecodingMode/EntityDecoder/fromCodePoint/htmlDecodeTree through entities/dist/decode.js is consistent with the v5 layout and keeps all usage in non‑__BROWSER__ branches, so the non‑browser‑only dependency contract still holds. As with parser.ts, this is a deep import into dist/; if a later bump to entities >5 switches to only exporting ./decode / ./escape, this path will become invalid again. It’s worth planning to swap to the public entities/decode subpath once you’ve confirmed it’s exported in 5.0.0.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25ebe3a and b6d994f.

📒 Files selected for processing (3)

packages/compiler-core/package.json (1 hunks)
packages/compiler-core/src/parser.ts (1 hunks)
packages/compiler-core/src/tokenizer.ts (1 hunks)

🔇 Additional comments (1)

packages/compiler-core/package.json (1)

48-54: entities bump to ^5.0.0 aligns with the new imports; verify runtime behavior

Updating entities to ^5.0.0 matches the new dist-based imports and should address the Node 24 path-resolution issue. Since this is a major bump with a different layout, make sure the compiler-core test suite (especially entity decoding and tokenizer/parser specs) passes under Node 24 with a fresh install so we don’t miss any subtle behavior changes.

edison1105 · 2025-12-03T00:18:49Z

Thanks for this PR, but v5.0.0 will bring #11603 back. see e9e0815

The entities package v4.5.0 uses lib/ directory for exports which causes ERR_PACKAGE_PATH_NOT_EXPORTED error in Node.js 24 due to stricter exports map resolution. Updated entities to v6.0.0 which properly exports './decode' subpath that is compatible with Node.js 24's exports resolution. Note: v5.0.0 was previously tried but caused runtime resolution errors (issue vuejs#11603). v6.0.0 resolves both issues by using clean subpath exports ('./decode' instead of './lib/decode.js' or './dist/decode.js'). close vuejs#14159

github-actions · 2025-12-03T02:01:09Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	103 kB	39 kB	35.1 kB
vue.global.prod.js	161 kB	58.9 kB	52.6 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	47 kB	18.3 kB	16.8 kB
createApp	55.1 kB	21.4 kB	19.6 kB
createSSRApp	59.4 kB	23.2 kB	21.1 kB
defineCustomElement	60.7 kB	23.1 kB	21.1 kB
overall	69.4 kB	26.6 kB	24.3 kB

pkg-pr-new · 2025-12-03T02:01:15Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14160

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14160

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14160

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14160

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14160

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14160

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14160

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14160

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14160

vue

npm i https://pkg.pr.new/vue@14160

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14160

commit: 9a6640f

edison1105 · 2025-12-03T02:29:08Z

I tested that "entities": "^6.0.0" does not cause a regression of #11603. Perhaps we can try upgrading it to 7.0.0.

edison1105 · 2025-12-03T07:20:32Z

/ecosystem-ci run

vue-bot · 2025-12-03T07:40:17Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
quasar	✅ success	✅ success
test-utils	✅ success	✅ success
radix-vue	✅ success	✅ success
pinia	✅ success	✅ success
primevue	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vuetify	❌ failure	❌ failure
router	❌ failure	❌ failure
vue-macros	❌ failure	❌ failure
language-tools	✅ success	✅ success
vant	✅ success	✅ success
vue-i18n	❌ failure	❌ failure
vitepress	✅ success	✅ success
vueuse	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success
nuxt	✅ success	✅ success

kTelyakov · 2025-12-03T19:17:48Z

@edison1105 Please tell me when this pull request will be merged ?

coderabbitai bot reviewed Dec 2, 2025

View reviewed changes

kTelyakov force-pushed the fix-entities-node24-compatibility branch from b6d994f to 8b04784 Compare December 2, 2025 20:36

edison1105 added the wait changes label Dec 3, 2025

kTelyakov force-pushed the fix-entities-node24-compatibility branch 2 times, most recently from 148839f to f670c51 Compare December 3, 2025 01:38

kTelyakov force-pushed the fix-entities-node24-compatibility branch from f670c51 to cb60bba Compare December 3, 2025 01:39

edison1105 added ready to merge The PR is ready to be merged. dependencies Pull requests that update a dependency file and removed wait changes labels Dec 3, 2025

edison1105 changed the title ~~fix(compiler-core): update entities to v5 for Node.js 24 compatibility~~ chore(deps): update entities to latest for Node.js 24 compatibility Dec 3, 2025

edison1105 added this to Next Minor Dec 3, 2025

edison1105 removed this from Next Minor Dec 3, 2025

chore(deps): update entities package to v7.0.0

9a6640f

vuejs deleted a comment from edison1105 Dec 3, 2025

edison1105 merged commit 1e34871 into vuejs:main Dec 15, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update entities to latest for Node.js 24 compatibility#14160

chore(deps): update entities to latest for Node.js 24 compatibility#14160
edison1105 merged 2 commits intovuejs:mainfrom
kTelyakov:fix-entities-node24-compatibility

kTelyakov commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

pkg-pr-new bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

vue-bot commented Dec 3, 2025

Uh oh!

kTelyakov commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kTelyakov commented Dec 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

netlify bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Uh oh!

netlify bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for vue-next-template-explorer failed. Why did it fail? →

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

edison1105 commented Dec 3, 2025

Uh oh!

vue-bot commented Dec 3, 2025

Uh oh!

kTelyakov commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kTelyakov commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

netlify bot commented Dec 2, 2025 •

edited

Loading

netlify bot commented Dec 2, 2025 •

edited

Loading

pkg-pr-new bot commented Dec 3, 2025 •

edited

Loading